[ruby/openssl] Exact checks with assert_include

Where `assert_match` converts string matcher argument to regexp first
with escaping, `assert_include` does the same thing simpler.

https://github.com/ruby/openssl/commit/81007e0a49
This commit is contained in:
Nobuyoshi Nakada 2023-10-06 17:38:56 +09:00 committed by git
parent 95ced6d8d2
commit 723318f5d7

View File

@ -50,18 +50,16 @@ class OpenSSL::TestX509Extension < OpenSSL::TestCase
cdp = ef.create_extension("crlDistributionPoints", "@crlDistPts") cdp = ef.create_extension("crlDistributionPoints", "@crlDistPts")
assert_equal(false, cdp.critical?) assert_equal(false, cdp.critical?)
assert_equal("crlDistributionPoints", cdp.oid) assert_equal("crlDistributionPoints", cdp.oid)
assert_match(%{URI:http://www\.example\.com/crl}, cdp.value) assert_include(cdp.value, "URI:http://www.example.com/crl")
assert_match( assert_include(cdp.value,
%r{URI:ldap://ldap\.example\.com/cn=ca\?certificateRevocationList;binary}, "URI:ldap://ldap.example.com/cn=ca?certificateRevocationList;binary")
cdp.value)
cdp = ef.create_extension("crlDistributionPoints", "critical, @crlDistPts") cdp = ef.create_extension("crlDistributionPoints", "critical, @crlDistPts")
assert_equal(true, cdp.critical?) assert_equal(true, cdp.critical?)
assert_equal("crlDistributionPoints", cdp.oid) assert_equal("crlDistributionPoints", cdp.oid)
assert_match(%{URI:http://www.example.com/crl}, cdp.value) assert_include(cdp.value, "URI:http://www.example.com/crl")
assert_match( assert_include(cdp.value,
%r{URI:ldap://ldap.example.com/cn=ca\?certificateRevocationList;binary}, "URI:ldap://ldap.example.com/cn=ca?certificateRevocationList;binary")
cdp.value)
cp = ef.create_extension("certificatePolicies", "@certPolicies") cp = ef.create_extension("certificatePolicies", "@certPolicies")
assert_equal(false, cp.critical?) assert_equal(false, cp.critical?)