From 71baa6943ba755963e95735dd8c5750933d1879e Mon Sep 17 00:00:00 2001 From: Jean Boussier Date: Thu, 8 May 2025 09:05:28 +0200 Subject: [PATCH] variable.c: Fix compilation warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ``` variable.c: In function ‘iterate_over_shapes_with_callback’: variable.c:2188:1: warning: control reaches end of non-void function [-Wreturn-type] 2188 | } | ^ variable.c: In function ‘rb_field_get’: variable.c:1322:43: warning: ‘fields_tbl’ may be used uninitialized [-Wmaybe-uninitialized] 1322 | return fields_tbl->as.shape.fields[attr_index]; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ variable.c:1319:32: note: ‘fields_tbl’ was declared here 1319 | struct gen_fields_tbl *fields_tbl; | ``` --- variable.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/variable.c b/variable.c index bcd1d9ba6c..f6830cd3cf 100644 --- a/variable.c +++ b/variable.c @@ -1316,7 +1316,7 @@ rb_field_get(VALUE obj, rb_shape_t *target_shape) return ROBJECT_FIELDS(obj)[attr_index]; default: RUBY_ASSERT(FL_TEST_RAW(obj, FL_EXIVAR)); - struct gen_fields_tbl *fields_tbl; + struct gen_fields_tbl *fields_tbl = NULL; rb_ivar_generic_fields_tbl_lookup(obj, &fields_tbl); RUBY_ASSERT(fields_tbl); return fields_tbl->as.shape.fields[attr_index]; @@ -2184,6 +2184,7 @@ iterate_over_shapes_with_callback(rb_shape_t *shape, rb_ivar_foreach_callback_fu return iterate_over_shapes_with_callback(rb_shape_get_parent(shape), callback, itr_data); case SHAPE_OBJ_TOO_COMPLEX: rb_bug("Unreachable"); + UNREACHABLE_RETURN(false); } }