1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[rubygems/rubygems] Do not compare with unreliable Gem::Specification::TODAY

Browse Source 
https://gist.github.com/ko1/a88834d744a0682711dab53fd9015a04#file-brlog-trunk-nopara-20191005-235153-L393-L472

https://github.com/rubygems/rubygems/commit/707408d8e7
This commit is contained in:
Nobuyoshi Nakada 2019-10-07 00:12:18 +09:00
parent dc2b301994
commit 6f522455bf
1 changed files with 18 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
test/rubygems/test_gem_specification.rb
View File

@ -74,6 +74,12 @@ end
end end
end end
def assert_date(date)
assert_kind_of Time, date
assert_equal [0, 0, 0], [date.hour, date.min, date.sec]
assert_operator (Gem::Specification::TODAY..Time.now), :cover?, date
end
def setup def setup
super super
@ -1035,7 +1041,7 @@ dependencies: []
end end
assert_equal 'keyedlist', spec.name assert_equal 'keyedlist', spec.name
assert_equal '0.4.0', spec.version.to_s assert_equal '0.4.0', spec.version.to_s
assert_equal Gem::Specification::TODAY, spec.date assert_kind_of Time, spec.date
assert spec.required_ruby_version.satisfied_by?(Gem::Version.new('1')) assert spec.required_ruby_version.satisfied_by?(Gem::Version.new('1'))
assert_equal false, spec.has_unit_tests? assert_equal false, spec.has_unit_tests?
end end
@ -1694,10 +1700,7 @@ dependencies: []
end end
def test_date def test_date
today = Gem::Specification::TODAY assert_date @a1.date
a1_date = @a1.date
now = Time.now
assert_operator (today..now), :cover?, a1_date
end end
def test_date_equals_date def test_date_equals_date
@ -2421,7 +2424,7 @@ Gem::Specification.new do |s|
s.required_rubygems_version = Gem::Requirement.new(\"> 0\".freeze) if s.respond_to? :required_rubygems_version= s.required_rubygems_version = Gem::Requirement.new(\"> 0\".freeze) if s.respond_to? :required_rubygems_version=
s.require_paths = ["lib".freeze, "other".freeze] s.require_paths = ["lib".freeze, "other".freeze]
s.authors = ["A User".freeze] s.authors = ["A User".freeze]
s.date = "#{Gem::Specification::TODAY.strftime "%Y-%m-%d"}" s.date = "#{@a2.date.strftime("%Y-%m-%d")}"
s.description = "This is a test description".freeze s.description = "This is a test description".freeze
s.email = "example@example.com".freeze s.email = "example@example.com".freeze
s.files = ["lib/code.rb".freeze] s.files = ["lib/code.rb".freeze]
@ -2464,7 +2467,7 @@ Gem::Specification.new do |s|
s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version= s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
s.require_paths = ["lib".freeze] s.require_paths = ["lib".freeze]
s.authors = ["A User".freeze] s.authors = ["A User".freeze]
s.date = "#{Gem::Specification::TODAY.strftime "%Y-%m-%d"}" s.date = "#{@a2.date.strftime("%Y-%m-%d")}"
s.description = "This is a test description".freeze s.description = "This is a test description".freeze
s.email = "example@example.com".freeze s.email = "example@example.com".freeze
s.files = ["lib/code.rb".freeze] s.files = ["lib/code.rb".freeze]
@ -2497,7 +2500,7 @@ Gem::Specification.new do |s|
s.required_rubygems_version = Gem::Requirement.new(\"> 0\".freeze) if s.respond_to? :required_rubygems_version= s.required_rubygems_version = Gem::Requirement.new(\"> 0\".freeze) if s.respond_to? :required_rubygems_version=
s.require_paths = ["lib".freeze] s.require_paths = ["lib".freeze]
s.authors = ["A User".freeze] s.authors = ["A User".freeze]
s.date = "#{Gem::Specification::TODAY.strftime "%Y-%m-%d"}" s.date = "#{@a2.date.strftime("%Y-%m-%d")}"
s.description = "This is a test description".freeze s.description = "This is a test description".freeze
s.email = "example@example.com".freeze s.email = "example@example.com".freeze
s.homepage = "http://example.com".freeze s.homepage = "http://example.com".freeze
@ -2552,7 +2555,7 @@ Gem::Specification.new do |s|
s.required_rubygems_version = Gem::Requirement.new(\">= 0\".freeze) if s.respond_to? :required_rubygems_version= s.required_rubygems_version = Gem::Requirement.new(\">= 0\".freeze) if s.respond_to? :required_rubygems_version=
s.require_paths = ["lib".freeze] s.require_paths = ["lib".freeze]
s.authors = ["A User".freeze] s.authors = ["A User".freeze]
s.date = "#{Gem::Specification::TODAY.strftime "%Y-%m-%d"}" s.date = "#{@c1.date.strftime("%Y-%m-%d")}"
s.description = "This is a test description".freeze s.description = "This is a test description".freeze
s.email = "example@example.com".freeze s.email = "example@example.com".freeze
s.executables = ["exec".freeze] s.executables = ["exec".freeze]
@ -3624,6 +3627,11 @@ Did you mean 'Ruby'?
end end
def test_metadata_specs def test_metadata_specs
@m1 = quick_gem 'm', '1' do |s|
s.files = %w[lib/code.rb]
s.metadata = { 'one' => "two", 'two' => "three" }
end
valid_ruby_spec = <<-EOF valid_ruby_spec = <<-EOF
# -*- encoding: utf-8 -*- # -*- encoding: utf-8 -*-
# stub: m 1 ruby lib # stub: m 1 ruby lib
@ -3636,7 +3644,7 @@ Gem::Specification.new do |s|
s.metadata = { "one" => "two", "two" => "three" } if s.respond_to? :metadata= s.metadata = { "one" => "two", "two" => "three" } if s.respond_to? :metadata=
s.require_paths = ["lib".freeze] s.require_paths = ["lib".freeze]
s.authors = ["A User".freeze] s.authors = ["A User".freeze]
s.date = "#{Gem::Specification::TODAY.strftime("%Y-%m-%d")}" s.date = "#{@m1.date.strftime("%Y-%m-%d")}"
s.description = "This is a test description".freeze s.description = "This is a test description".freeze
s.email = "example@example.com".freeze s.email = "example@example.com".freeze
s.files = ["lib/code.rb".freeze] s.files = ["lib/code.rb".freeze]
@ -3646,11 +3654,6 @@ Gem::Specification.new do |s|
end end
EOF EOF
@m1 = quick_gem 'm', '1' do |s|
s.files = %w[lib/code.rb]
s.metadata = { 'one' => "two", 'two' => "three" }
end
assert_equal @m1.to_ruby, valid_ruby_spec assert_equal @m1.to_ruby, valid_ruby_spec
end end