diff --git a/ChangeLog b/ChangeLog index 96b8fd5093..01c42ad876 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +Fri Oct 15 17:26:57 2010 NARUSE, Yui + + * pack.c (pack_pack): simplify comparison of explicit_endian + as pointed by nobu. + + * pack.c (pack_unpack): ditto. + Thu Oct 14 09:46:28 2010 NARUSE, Yui * sprintf.c (rb_str_format): fix: sprintf with hex format and diff --git a/pack.c b/pack.c index 45a5de0d4f..5d89efcaf2 100644 --- a/pack.c +++ b/pack.c @@ -770,7 +770,7 @@ pack_pack(VALUE ary, VALUE fmt) pack_integer: if (explicit_endian) { - bigendian_p = ((explicit_endian - '<') != 0); + bigendian_p = explicit_endian == '>'; } switch (integer_size) { @@ -1666,7 +1666,7 @@ pack_unpack(VALUE str, VALUE fmt) unpack_integer: if (explicit_endian) { - bigendian_p = ((explicit_endian - '<') != 0); + bigendian_p = explicit_endian == '>'; } switch (integer_size) {