1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rb_bug if rb_gc_impl_active_gc_name is too long

Browse Source 
This avoids the need to malloc, and reduces the complexity of truncating
the long string for display in RUBY_DESCRIPTION.

The developer of a GC implementation should be responsible for giving it
a succinct name.
This commit is contained in:
Matt Valentine-House 2024-11-08 20:58:53 +00:00
parent ee290c94a3
commit 6795fc4981
Notes: git 2024-11-14 10:46:54 +00:00 
Merged: https://github.com/ruby/ruby/pull/11872
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gc.c
View File

@ -2780,13 +2780,8 @@ rb_gc_active_gc_name(void)
{
const char *gc_name = rb_gc_impl_active_gc_name();
if (strlen(gc_name) > RB_GC_MAX_NAME_LEN) {
char *truncated_gc_name = ruby_xmalloc(RB_GC_MAX_NAME_LEN + 1);
rb_warn("GC module %s has a name larger than %d chars, it will be truncated\n",
gc_name, RB_GC_MAX_NAME_LEN);
strncpy(truncated_gc_name, gc_name, RB_GC_MAX_NAME_LEN);
return (const char *)truncated_gc_name;
rb_bug("GC should have a name shorter than %d chars. Currently: %lu (%s)\n",
RB_GC_MAX_NAME_LEN, strlen(gc_name), gc_name);
}
return gc_name;