1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

get_pat: do not goto into a branch

Browse Source 
I'm not necessarily against every goto in general, but jumping into a
branch is definitely a bad idea.  Better refactor.
This commit is contained in:
卜部昌平 2020-06-18 15:24:16 +09:00
parent 31e5d138d7
commit 673ddea934
Notes: git 2020-06-29 11:06:46 +09:00 
Merged: https://github.com/ruby/ruby/pull/3247
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
string.c
View File

@ -5009,8 +5009,7 @@ get_pat(VALUE pat)
{ {
VALUE val; VALUE val;
if (SPECIAL_CONST_P(pat)) goto to_string; switch (OBJ_BUILTIN_TYPE(pat)) {
switch (BUILTIN_TYPE(pat)) {
case T_REGEXP: case T_REGEXP:
return pat; return pat;
@ -5018,7 +5017,6 @@ get_pat(VALUE pat)
break; break;
default: default:
to_string:
val = rb_check_string_type(pat); val = rb_check_string_type(pat);
if (NIL_P(val)) { if (NIL_P(val)) {
Check_Type(pat, T_REGEXP); Check_Type(pat, T_REGEXP);