1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

avoid seeding

Browse Source 
OpenSSL's man page previously stated that "the application is
responsible for seeding the PRNG by calling RAND_add" (see [1]).
So we had this code.  However things changed.  They no longer
say so, instead "manual (re-)seeding of the default OpenSSL
random generator is not necessary" now (see [2]).  It seems all
OpenSSL versions that we support now already behaves like this.
Let's follow that.

[1]: https://www.openssl.org/docs/man1.0.2/man3/RAND_add.html
[2]: https://www.openssl.org/docs/manmaster/man3/RAND_add.html
This commit is contained in:
卜部昌平 2023-04-13 15:36:24 +09:00
parent 0a092d00cc
commit 64e503eb62
Notes: git 2023-04-13 10:50:23 +00:00 
Merged: https://github.com/ruby/ruby/pull/7705
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/securerandom.rb
View File

@ -47,17 +47,6 @@ module SecureRandom
private private
def gen_random_openssl(n) def gen_random_openssl(n)
@pid = 0 unless defined?(@pid)
pid = $$
unless @pid == pid
now = Process.clock_gettime(Process::CLOCK_REALTIME, :nanosecond)
OpenSSL::Random.random_add([now, @pid, pid].join(""), 0.0)
seed = Random.urandom(16)
if (seed)
OpenSSL::Random.random_add(seed, 16)
end
@pid = pid
end
return OpenSSL::Random.random_bytes(n) return OpenSSL::Random.random_bytes(n)
end end