1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

class.c (Class#descendants): Ingore subclasses created after estimation

Browse Source 
It is theoretically possible if a finalizer creates a subclass.
This commit is contained in:
Yusuke Endoh 2021-11-05 09:36:44 +09:00
parent 037da50666
commit 64007fc57f
Notes: git 2021-11-09 16:11:32 +09:00 
Merged: https://github.com/ruby/ruby/pull/5070
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
class.c
View File

@ -1340,6 +1340,7 @@ struct subclass_traverse_data
{
VALUE *buffer;
long count;
long maxcount;
};
static void
@ -1348,7 +1349,7 @@ class_descendants_recursive(VALUE klass, VALUE v)
struct subclass_traverse_data *data = (struct subclass_traverse_data *) v;
if (BUILTIN_TYPE(klass) == T_CLASS && !FL_TEST(klass, FL_SINGLETON)) {
if (data->buffer) {
if (data->buffer && (data->count < data->maxcount || data->maxcount == -1)) {
data->buffer[data->count] = klass;
}
data->count++;
@ -1377,13 +1378,14 @@ class_descendants_recursive(VALUE klass, VALUE v)
VALUE
rb_class_descendants(VALUE klass)
{
struct subclass_traverse_data data = { NULL, 0 };
struct subclass_traverse_data data = { NULL, 0, -1 };
// estimate the count of subclasses
rb_class_foreach_subclass(klass, class_descendants_recursive, (VALUE) &data);
// this allocation may cause GC which may reduce the subclasses
data.buffer = ALLOC_N(VALUE, data.count);
data.maxcount = data.count;
data.count = 0;
// enumerate subclasses