Fix handling of error/errno in io_internal_wait. (#12961)

[Bug #21195]
This commit is contained in:
Samuel Williams 2025-03-23 13:42:04 +13:00 committed by GitHub
parent eb91c664dc
commit 5f77f9bea6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
Notes: git 2025-03-23 00:42:21 +00:00
Merged-By: ioquatix <samuel@codeotaku.com>
2 changed files with 34 additions and 2 deletions

10
io.c
View File

@ -1181,8 +1181,14 @@ io_internal_wait(VALUE thread, rb_io_t *fptr, int error, int events, struct time
return -1;
}
errno = error;
return -1;
// If there was an error BEFORE we started waiting, return it:
if (error) {
errno = error;
return -1;
} else {
// Otherwise, whatever error was generated by `nogvl_wait_for` is the one we want:
return ready;
}
}
static VALUE

View File

@ -4373,4 +4373,30 @@ __END__
end
end
end
def test_blocking_timeout
assert_separately([], <<~'RUBY')
IO.pipe do |r, w|
trap(:INT) do
w.puts "INT"
end
main = Thread.current
thread = Thread.new do
# Wait until the main thread has entered `$stdin.gets`:
Thread.pass until main.status == 'sleep'
# Cause an interrupt while handling `$stdin.gets`:
Process.kill :INT, $$
end
r.timeout = 1
assert_equal("INT", r.gets.chomp)
rescue IO::TimeoutError
# Ignore - some platforms don't support interrupting `gets`.
ensure
thread&.join
end
RUBY
end
end