From 5d1702e01a36e11b183fe29ce10780a9b1a41cf0 Mon Sep 17 00:00:00 2001 From: Samuel Williams Date: Mon, 8 Apr 2024 00:49:01 +1200 Subject: [PATCH] Enumerator should use a non-blocking fiber, change `rb_fiber_new` to be non-blocking by default. (#10481) --- cont.c | 2 +- test/fiber/test_enumerator.rb | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/cont.c b/cont.c index c6a94e0709..f7a4863f2c 100644 --- a/cont.c +++ b/cont.c @@ -2382,7 +2382,7 @@ rb_fiber_initialize(int argc, VALUE* argv, VALUE self) VALUE rb_fiber_new_storage(rb_block_call_func_t func, VALUE obj, VALUE storage) { - return fiber_initialize(fiber_alloc(rb_cFiber), rb_proc_new(func, obj), rb_fiber_pool_default(Qnil), 1, storage); + return fiber_initialize(fiber_alloc(rb_cFiber), rb_proc_new(func, obj), rb_fiber_pool_default(Qnil), 0, storage); } VALUE diff --git a/test/fiber/test_enumerator.rb b/test/fiber/test_enumerator.rb index 40f7d01725..e9410f925c 100644 --- a/test/fiber/test_enumerator.rb +++ b/test/fiber/test_enumerator.rb @@ -42,4 +42,12 @@ class TestFiberEnumerator < Test::Unit::TestCase assert_predicate(i, :closed?) assert_predicate(o, :closed?) end + + def enumerator_fiber_is_nonblocking + enumerator = Enumerator.new do |yielder| + yielder << Fiber.current.blocking? + end + + assert_equal(false, enumerator.next) + end end