From 5a9984d7aa30f0d6febc3415d189fa81563d70a5 Mon Sep 17 00:00:00 2001 From: akr Date: Sat, 8 Jun 2013 14:14:46 +0000 Subject: [PATCH] * marshal.c (r_object0): Use rb_integer_unpack. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@41181 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 4 ++++ marshal.c | 37 ++++--------------------------------- 2 files changed, 8 insertions(+), 33 deletions(-) diff --git a/ChangeLog b/ChangeLog index d218a64d6d..dab3eac206 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +Sat Jun 8 22:53:45 2013 Tanaka Akira + + * marshal.c (r_object0): Use rb_integer_unpack. + Sat Jun 8 22:18:57 2013 Tanaka Akira * time.c (v2w): Use rb_absint_size instead of RBIGNUM_LEN. diff --git a/marshal.c b/marshal.c index e5ded68f05..b4ba0f3120 100644 --- a/marshal.c +++ b/marshal.c @@ -1610,44 +1610,15 @@ r_object0(struct load_arg *arg, int *ivp, VALUE extmod) case TYPE_BIGNUM: { long len; - BDIGIT *digits; VALUE data; + int sign; - NEWOBJ_OF(big, struct RBignum, rb_cBignum, T_BIGNUM | (RGENGC_WB_PROTECTED_BIGNUM ? FL_WB_PROTECTED : 0)); - RBIGNUM_SET_SIGN(big, (r_byte(arg) == '+')); + sign = r_byte(arg); len = r_long(arg); data = r_bytes0(len * 2, arg); -#if SIZEOF_BDIGITS == SIZEOF_SHORT - rb_big_resize((VALUE)big, len); -#else - rb_big_resize((VALUE)big, (len * 2 + sizeof(BDIGIT) - 1) / sizeof(BDIGIT)); -#endif - digits = RBIGNUM_DIGITS(big); - MEMCPY(digits, RSTRING_PTR(data), char, len * 2); + v = rb_integer_unpack(sign == '-' ? -1 : +1, RSTRING_PTR(data), len, 2, 0, + INTEGER_PACK_LITTLE_ENDIAN); rb_str_resize(data, 0L); -#if SIZEOF_BDIGITS > SIZEOF_SHORT - MEMZERO((char *)digits + len * 2, char, - RBIGNUM_LEN(big) * sizeof(BDIGIT) - len * 2); -#endif - len = RBIGNUM_LEN(big); - while (len > 0) { - unsigned char *p = (unsigned char *)digits; - BDIGIT num = 0; -#if SIZEOF_BDIGITS > SIZEOF_SHORT - int shift = 0; - int i; - - for (i=0; i