1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

lldb: Warn when attempting to dump invalid pages

Browse Source
This commit is contained in:
Matt Valentine-House 2021-04-29 17:02:02 +01:00 committed by Peter Zhu
parent dfca24af82
commit 5a451c4b1f
Notes: git 2021-04-30 04:13:55 +09:00 
Merged: https://github.com/ruby/ruby/pull/4431
1 changed files with 32 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
misc/lldb_cruby.py
View File

@ -13,6 +13,8 @@ import shlex
HEAP_PAGE_ALIGN_LOG = 14 HEAP_PAGE_ALIGN_LOG = 14
HEAP_PAGE_ALIGN_MASK = (~(~0 << HEAP_PAGE_ALIGN_LOG)) HEAP_PAGE_ALIGN_MASK = (~(~0 << HEAP_PAGE_ALIGN_LOG))
HEAP_PAGE_ALIGN = (1 << HEAP_PAGE_ALIGN_LOG)
HEAP_PAGE_SIZE = HEAP_PAGE_ALIGN
class BackTrace: class BackTrace:
VM_FRAME_MAGIC_METHOD = 0x11110001 VM_FRAME_MAGIC_METHOD = 0x11110001
@ -537,6 +539,16 @@ class HeapPageIter:
self.tRBasic = target.FindFirstType("struct RBasic") self.tRBasic = target.FindFirstType("struct RBasic")
self.tRValue = target.FindFirstType("struct RVALUE") self.tRValue = target.FindFirstType("struct RVALUE")
def is_valid(self):
heap_page_header_size = self.target.FindFirstType("struct heap_page_header").GetByteSize()
rvalue_size = self.tRValue.GetByteSize()
heap_page_obj_limit = (HEAP_PAGE_SIZE - heap_page_header_size)/rvalue_size
if (self.num_slots > heap_page_obj_limit) or (self.num_slots < heap_page_obj_limit - 1):
return False
else:
return True
def __iter__(self): def __iter__(self):
return self return self
@ -568,24 +580,30 @@ def dump_page_internal(page, target, process, thread, frame, result, debugger, h
obj = target.CreateValueFromAddress("object", obj_addr, tRVALUE) obj = target.CreateValueFromAddress("object", obj_addr, tRVALUE)
fl_start = obj.GetChildMemberWithName("as").GetChildMemberWithName("free").GetChildMemberWithName("next").GetValueAsUnsigned() fl_start = obj.GetChildMemberWithName("as").GetChildMemberWithName("free").GetChildMemberWithName("next").GetValueAsUnsigned()
for (page_index, obj_addr, obj) in HeapPageIter(page, target):
dump_bits(target, result, page, obj_addr, end= " ")
flags = obj.GetChildMemberWithName('flags').GetValueAsUnsigned()
flType = flags & RUBY_T_MASK
flidx = ' ' page_iter = HeapPageIter(page, target)
if flType == RUBY_T_NONE: if page_iter.is_valid():
try: for (page_index, obj_addr, obj) in page_iter:
flidx = "%3d" % freelist.index(obj_addr) dump_bits(target, result, page, obj_addr, end= " ")
except ValueError: flags = obj.GetChildMemberWithName('flags').GetValueAsUnsigned()
flidx = ' ' flType = flags & RUBY_T_MASK
result_str = "%s idx: [%3d] freelist_idx: {%s} Addr: %0#x (flags: %0#x)" % (rb_type(flags, ruby_type_map), page_index, flidx, obj_addr, flags) flidx = ' '
if flType == RUBY_T_NONE:
try:
flidx = "%3d" % freelist.index(obj_addr)
except ValueError:
flidx = ' '
if highlight == obj_addr: result_str = "%s idx: [%3d] freelist_idx: {%s} Addr: %0#x (flags: %0#x)" % (rb_type(flags, ruby_type_map), page_index, flidx, obj_addr, flags)
result_str = ' '.join([result_str, "<<<<<"])
if highlight == obj_addr:
result_str = ' '.join([result_str, "<<<<<"])
print(result_str, file=result)
else:
print("%s is not a valid heap page" % page, file=result)
print(result_str, file=result)
def dump_page(debugger, command, result, internal_dict): def dump_page(debugger, command, result, internal_dict):