1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/prism] Static literal flag for string hash keys

Browse Source 
https://github.com/ruby/prism/commit/26a2d774cd
This commit is contained in:
Kevin Newton 2024-01-22 11:19:27 -05:00 committed by git
parent 6401f282d2
commit 5906ce42fe
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
prism/prism.c
View File

@ -1352,6 +1352,13 @@ pm_assoc_node_create(pm_parser_t *parser, pm_node_t *key, const pm_token_t *oper
end = key->location.end; end = key->location.end;
} }
// Hash string keys will be frozen, so we can mark them as frozen here so
// that the compiler picks them up and also when we check for static literal
// on the keys it gets factored in.
if (PM_NODE_TYPE_P(key, PM_STRING_NODE)) {
key->flags |= PM_STRING_FLAGS_FROZEN | PM_NODE_FLAG_STATIC_LITERAL;
}
// If the key and value of this assoc node are both static literals, then // If the key and value of this assoc node are both static literals, then
// we can mark this node as a static literal. // we can mark this node as a static literal.
pm_node_flags_t flags = 0; pm_node_flags_t flags = 0;
@ -1359,11 +1366,6 @@ pm_assoc_node_create(pm_parser_t *parser, pm_node_t *key, const pm_token_t *oper
flags = key->flags & value->flags & PM_NODE_FLAG_STATIC_LITERAL; flags = key->flags & value->flags & PM_NODE_FLAG_STATIC_LITERAL;
} }
// Hash string keys should be frozen
if (PM_NODE_TYPE_P(key, PM_STRING_NODE)) {
key->flags |= PM_STRING_FLAGS_FROZEN;
}
*node = (pm_assoc_node_t) { *node = (pm_assoc_node_t) {
{ {
.type = PM_ASSOC_NODE, .type = PM_ASSOC_NODE,