1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't disable GC in rb_gc_impl_object_id

Browse Source 
Disabling GC when creating the object ID was introduced in commit
67b2c21, but we shouldn't need to disable the GC.
This commit is contained in:
Peter Zhu 2024-07-17 14:52:02 -04:00
parent 2cc20c06e0
commit 573c2893dc
Notes: git 2024-07-17 19:46:59 +00:00 
Merged: https://github.com/ruby/ruby/pull/11189
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gc/default.c
View File

@ -1691,11 +1691,8 @@ rb_gc_impl_object_id(void *objspace_ptr, VALUE obj)
id = ULL2NUM(objspace->next_object_id); id = ULL2NUM(objspace->next_object_id);
objspace->next_object_id += OBJ_ID_INCREMENT; objspace->next_object_id += OBJ_ID_INCREMENT;
bool prev_enabled = rb_gc_impl_gc_enabled_p(objspace);
rb_gc_impl_gc_disable(objspace, false);
st_insert(objspace->obj_to_id_tbl, (st_data_t)obj, (st_data_t)id); st_insert(objspace->obj_to_id_tbl, (st_data_t)obj, (st_data_t)id);
st_insert(objspace->id_to_obj_tbl, (st_data_t)id, (st_data_t)obj); st_insert(objspace->id_to_obj_tbl, (st_data_t)id, (st_data_t)obj);
if (prev_enabled) rb_gc_impl_gc_enable(objspace);
FL_SET(obj, FL_SEEN_OBJ_ID); FL_SET(obj, FL_SEEN_OBJ_ID);
} }
rb_gc_vm_unlock(lev); rb_gc_vm_unlock(lev);