1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Bug #19004] Complex.polar handles complex singular abs argument

Browse Source 
`Complex.polar` accepts Complex values as arguments for the polar form as long
as the value of the complex has no imaginary part (ie it is 'real'). In
`f_complex_polar` this is handled by extracting the real part of the arguments.
However in the case `polar` is called with only a single argument, the absolute
value (abs), then the Complex is created without applying a check on the type
of abs, meaning it is possible to create a Complex where the real part is itself
an instance of a Complex. This change removes the short circuit for the single
argument case meaning the real part extraction is performed correctly
(by f_complex_polar).

Also adds an example to `spec/ruby/core/complex/polar_spec.rb` to check that
the real part of a complex argument is correctly extracted and used in the
resulting Complex real and imaginary parts.
This commit is contained in:
Stephen Ierodiaconou 2022-10-23 05:59:06 +02:00 committed by GitHub
parent 0d9628e0de
commit 54cad3123a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
Notes: git 2025-06-06 00:31:58 +00:00 
Merged: https://github.com/ruby/ruby/pull/6568

Merged-By: nobu <nobu@ruby-lang.org>
2 changed files with 22 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
complex.c
View File

@ -704,14 +704,13 @@ nucomp_s_polar(int argc, VALUE *argv, VALUE klass)
{
VALUE abs, arg;
switch (rb_scan_args(argc, argv, "11", &abs, &arg)) {
case 1:
nucomp_real_check(abs);
return nucomp_s_new_internal(klass, abs, ZERO);
default:
nucomp_real_check(abs);
argc = rb_scan_args(argc, argv, "11", &abs, &arg);
nucomp_real_check(abs);
if (argc == 2) {
nucomp_real_check(arg);
break;
}
else {
arg = ZERO;
}
return f_complex_polar(klass, abs, arg);
}

16
spec/ruby/core/complex/polar_spec.rb
View File

@ -10,6 +10,22 @@ describe "Complex.polar" do
->{ Complex.polar(nil) }.should raise_error(TypeError)
->{ Complex.polar(nil, nil) }.should raise_error(TypeError)
end
ruby_bug "#19004", ""..."3.2" do
it "computes the real values of the real & imaginary parts from the polar form" do
a = Complex.polar(1.0+0.0i, Math::PI/2+0.0i)
a.real.should be_close(0.0, TOLERANCE)
a.imag.should be_close(1.0, TOLERANCE)
a.real.real?.should be_true
a.imag.real?.should be_true
b = Complex.polar(1+0.0i)
b.real.should be_close(1.0, TOLERANCE)
b.imag.should be_close(0.0, TOLERANCE)
b.real.real?.should be_true
b.imag.real?.should be_true
end
end
end
describe "Complex#polar" do