From 53ba9fb74ec57c18c3589e2e51f84a36467e3d9e Mon Sep 17 00:00:00 2001 From: Yusuke Endoh Date: Mon, 31 Aug 2020 16:49:16 +0900 Subject: [PATCH] Prohibit setter method names in endless method definition https://bugs.ruby-lang.org/issues/16746#note-26 --- parse.y | 3 +++ test/ruby/test_syntax.rb | 1 + 2 files changed, 4 insertions(+) diff --git a/parse.y b/parse.y index 4efbd8c6d4..83e6d20ea6 100644 --- a/parse.y +++ b/parse.y @@ -2474,6 +2474,9 @@ arg : lhs '=' arg_rhs } | defn_head f_paren_args '=' arg { + if (is_attrset_id($1->nd_mid)) { + yyerror1(&@1, "setter method cannot be defined in an endless method definition"); + } token_info_drop(p, "def", @1.beg_pos); restore_defun(p, $1->nd_defn); /*%%%*/ diff --git a/test/ruby/test_syntax.rb b/test/ruby/test_syntax.rb index 546b5a27e1..fb982e8a1f 100644 --- a/test/ruby/test_syntax.rb +++ b/test/ruby/test_syntax.rb @@ -1429,6 +1429,7 @@ eom end assert_equal("class ok", k.rescued("ok")) assert_equal("instance ok", k.new.rescued("ok")) + assert_syntax_error('def foo=() = 42', /setter method cannot be defined in an endless method definition/) end def test_methoddef_in_cond