1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[rubygems/rubygems] Avoid unnecessary splat allocation

Browse Source 
Because get_push_scope is a method call, Ruby will allocate an array
for *args even though it is not necessary to do so. Using a local
variable avoids the allocation.

Found by the performance warning in Ruby feature 21274.

https://github.com/rubygems/rubygems/commit/0473c0cf32
This commit is contained in:
Jeremy Evans 2025-04-20 01:09:13 -07:00 committed by Hiroshi SHIBATA
parent 56c1a15eb7
commit 51d0e58772
No known key found for this signature in database
GPG Key ID: F9CF13417264FAC2
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/rubygems/commands/push_command.rb
View File

@ -92,7 +92,8 @@ The push command will use ~/.gem/credentials to authenticate to a server, but yo
private private
def send_push_request(name, args) def send_push_request(name, args)
rubygems_api_request(*args, scope: get_push_scope) do |request| scope = get_push_scope
rubygems_api_request(*args, scope: scope) do |request|
body = Gem.read_binary name body = Gem.read_binary name
if options[:attestations].any? if options[:attestations].any?
request.set_form([ request.set_form([