1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix String#sub for GC compaction

Browse Source 
The test fails when RGENGC_CHECK_MODE is turned on:

    TestString#test_sub_gc_compact_stress = 9.42 s
    1) Failure:
    TestString#test_sub_gc_compact_stress [test/ruby/test_string.rb:2089]:
    <"aaa [amp] yyy"> expected but was
    <"aaa [] yyy">.
This commit is contained in:
Peter Zhu 2023-12-23 16:22:14 -05:00
parent a2ebf9cc63
commit 50bf437341
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
string.c
View File

@ -5816,6 +5816,8 @@ rb_str_sub_bang(int argc, VALUE *argv, VALUE str)
TERM_FILL(&RSTRING_PTR(str)[len], TERM_LEN(str)); TERM_FILL(&RSTRING_PTR(str)[len], TERM_LEN(str));
ENC_CODERANGE_SET(str, cr); ENC_CODERANGE_SET(str, cr);
RB_GC_GUARD(match);
return str; return str;
} }
return Qnil; return Qnil;

9
test/ruby/test_string.rb
View File

@ -2081,6 +2081,15 @@ CODE
} }
end end
def test_sub_gc_compact_stress
EnvUtil.under_gc_compact_stress do
m = /&(?<foo>.*?);/.match(S("aaa &amp; yyy"))
assert_equal("amp", m["foo"])
assert_equal("aaa [amp] yyy", S("aaa &amp; yyy").sub(/&(?<foo>.*?);/, S('[\k<foo>]')))
end
end
def test_sub! def test_sub!
a = S("hello") a = S("hello")
b = a.dup b = a.dup