1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rb_str_bytesplice: skip encoding check if encodings are the same

Browse Source 
If both strings have the same encoding, all this work is useless.
This commit is contained in:
Jean Boussier 2024-08-08 11:48:04 +02:00
parent 3bac5f6af5
commit 4e85b6b4c4
Notes: git 2024-08-09 20:07:02 +00:00 
Merged: https://github.com/ruby/ruby/pull/11353
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
string.c
View File

@ -6571,7 +6571,6 @@ rb_str_bytesplice(int argc, VALUE *argv, VALUE str)
{
long beg, len, vbeg, vlen;
VALUE val;
rb_encoding *enc;
int cr;
rb_check_arity(argc, 2, 5);
@ -6616,10 +6615,13 @@ rb_str_bytesplice(int argc, VALUE *argv, VALUE str)
}
str_check_beg_len(str, &beg, &len);
str_check_beg_len(val, &vbeg, &vlen);
enc = rb_enc_check(str, val);
str_modify_keep_cr(str);
if (RB_UNLIKELY(ENCODING_GET_INLINED(str) != ENCODING_GET_INLINED(val))) {
rb_enc_associate(str, rb_enc_check(str, val));
}
rb_str_update_1(str, beg, len, val, vbeg, vlen);
rb_enc_associate(str, enc);
cr = ENC_CODERANGE_AND(ENC_CODERANGE(str), ENC_CODERANGE(val));
if (cr != ENC_CODERANGE_BROKEN)
ENC_CODERANGE_SET(str, cr);