1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

parse.y: relax literal in condition warnings

Browse Source 
* parse.y (cond0): do not warn literal boolean (true and false) in
  condition expressions, as they are often used as infinite loops,
  deactivated code block, etc.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63457 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
nobu 2018-05-18 00:36:24 +00:00
parent a20158381e
commit 4dc5b6ff58
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
parse.y
View File

@ -9823,6 +9823,10 @@ cond0(struct parser_params *p, NODE *node, int method_op, const YYLTYPE *loc)
warn_unless_e_option(p, node, "regex literal in condition"); warn_unless_e_option(p, node, "regex literal in condition");
nd_set_type(node, NODE_MATCH); nd_set_type(node, NODE_MATCH);
} }
else if (node->nd_lit == Qtrue ||
node->nd_lit == Qfalse) {
/* booleans are OK, e.g., while true */
}
else { else {
if (!method_op) if (!method_op)
parser_warning(p, node, "literal in condition"); parser_warning(p, node, "literal in condition");