1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

* variable.c (set_const_visibility): print a warning when no argument

Browse Source 
is passwd to Module#private_constant.  [ruby-list:48558]

* vm_method.c (set_method_visibility): ditto for
  Module#private_class_method.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@33936 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
mame 2011-12-03 11:52:14 +00:00
parent d267b2e347
commit 4a1cfe70dc
3 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
Sat Dec 3 20:49:16 2011 Yusuke Endoh <mame@tsg.ne.jp>
* variable.c (set_const_visibility): print a warning when no argument
is passwd to Module#private_constant. [ruby-list:48558]
* vm_method.c (set_method_visibility): ditto for
Module#private_class_method.
Sat Dec 3 20:43:14 2011 Yusuke Endoh <mame@tsg.ne.jp> Sat Dec 3 20:43:14 2011 Yusuke Endoh <mame@tsg.ne.jp>
* variable.c (set_const_visibility): Module#private_constant has * variable.c (set_const_visibility): Module#private_constant has

4
variable.c
View File

@ -2111,6 +2111,10 @@ set_const_visibility(VALUE mod, int argc, VALUE *argv, rb_const_flag_t flag)
"Insecure: can't change constant visibility"); "Insecure: can't change constant visibility");
} }
if (argc == 0) {
rb_warning("%s with no argument is just ignored", rb_id2name(rb_frame_callee()));
}
for (i = 0; i < argc; i++) { for (i = 0; i < argc; i++) {
VALUE val = argv[i]; VALUE val = argv[i];
id = rb_check_id(&val); id = rb_check_id(&val);

5
vm_method.c
View File

@ -985,6 +985,11 @@ set_method_visibility(VALUE self, int argc, VALUE *argv, rb_method_flag_t ex)
{ {
int i; int i;
secure_visibility(self); secure_visibility(self);
if (argc == 0) {
rb_warning("%s with no argument is just ignored", rb_id2name(rb_frame_callee()));
}
for (i = 0; i < argc; i++) { for (i = 0; i < argc; i++) {
VALUE v = argv[i]; VALUE v = argv[i];
ID id = rb_check_id(&v); ID id = rb_check_id(&v);