1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/rubygems] Refactor symlink attack specs

Browse Source 
https://github.com/rubygems/rubygems/commit/9180b390aa
This commit is contained in:
David Rodríguez 2021-09-30 15:06:22 +02:00 committed by git
parent 59c24f054e
commit 48e4dea4cd
1 changed files with 15 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
test/rubygems/test_gem_package.rb
View File

@ -574,18 +574,16 @@ class TestGemPackage < Gem::Package::TarTestCase
destination_subdir = File.join @destination, 'subdir'
FileUtils.mkdir_p destination_subdir
e = assert_raise(Gem::Package::PathError, Errno::EACCES) do
expected_exceptions = win_platform? ? [Gem::Package::PathError, Errno::EACCES] : [Gem::Package::PathError]
e = assert_raise(*expected_exceptions) do
package.extract_tar_gz tgz_io, destination_subdir
end
if Gem::Package::PathError === e
assert_equal("installing into parent path lib/link/outside.txt of " +
"#{destination_subdir} is not allowed", e.message)
elsif win_platform?
pend "symlink - must be admin with no UAC on Windows"
else
raise e
end
pend "symlink - must be admin with no UAC on Windows" if Errno::EACCES === e
assert_equal("installing into parent path lib/link/outside.txt of " +
"#{destination_subdir} is not allowed", e.message)
end
def test_extract_symlink_parent_doesnt_delete_user_dir
@ -608,20 +606,18 @@ class TestGemPackage < Gem::Package::TarTestCase
tar.add_symlink 'link/dir', '.', 16877
end
e = assert_raise(Gem::Package::PathError, Errno::EACCES) do
expected_exceptions = win_platform? ? [Gem::Package::PathError, Errno::EACCES] : [Gem::Package::PathError]
e = assert_raise(*expected_exceptions) do
package.extract_tar_gz tgz_io, destination_subdir
end
assert_path_exist destination_user_subdir
pend "symlink - must be admin with no UAC on Windows" if Errno::EACCES === e
if Gem::Package::PathError === e
assert_equal("installing into parent path #{destination_user_subdir} of " +
"#{destination_subdir} is not allowed", e.message)
elsif win_platform?
pend "symlink - must be admin with no UAC on Windows"
else
raise e
end
assert_equal("installing into parent path #{destination_user_subdir} of " +
"#{destination_subdir} is not allowed", e.message)
assert_path_exist destination_user_subdir
end
def test_extract_tar_gz_directory