1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tool/runruby.rb: remove LD_PRELOAD-like env-var options from runruby.rb

Browse Source 
LD_PRELOAD sometimes forces loading libraries into unrelated
executables. For example, macOS on recent Apple Silicon can execute
arm64 and arm64e binaries by default, and /usr/bin/clang is built as
arm64e. If Ruby is built as arm64, and mkmf launched through runruby.rb
spawns /usr/bin/clang, dynamic loader tries to load libruby (arm64e)
into clang (arm64). This force-load causes library load failure.
In theory, we don't need both LD_PRELOAD and LD_LIBRARY_PATH at the same
time, because executables requiring libruby already have libruby
dependency, so LD_LIBRARY_PATH is enough for this case.
This commit is contained in:
Yuta Saito 2022-12-04 06:34:55 +00:00
parent 3396b10ff1
commit 48644e7109
Notes: git 2022-12-05 08:24:35 +00:00 
Merged: https://github.com/ruby/ruby/pull/6857
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tool/runruby.rb
View File

@ -133,15 +133,6 @@ if File.file?(libruby_so)
if e = config['LIBPATHENV'] and !e.empty? if e = config['LIBPATHENV'] and !e.empty?
env[e] = [abs_archdir, ENV[e]].compact.join(File::PATH_SEPARATOR) env[e] = [abs_archdir, ENV[e]].compact.join(File::PATH_SEPARATOR)
end end
unless runner
if e = config['PRELOADENV']
e = nil if e.empty?
e ||= "LD_PRELOAD" if /linux/ =~ RUBY_PLATFORM
end
if e
env[e] = [libruby_so, ENV[e]].compact.join(File::PATH_SEPARATOR)
end
end
end end
ENV.update env ENV.update env