1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

YJIT: Update note about symbol prefixes [ci skip]

Browse Source
This commit is contained in:
Alan Wu 2022-06-17 18:12:55 -04:00
parent 566c5447ae
commit 41a024f2b9
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
yjit.c
View File

@ -56,13 +56,8 @@ STATIC_ASSERT(pointer_tagging_scheme, USE_FLONUM);
// types in C such as int, long, etc. and use `std::os::raw::c_long` and friends on // types in C such as int, long, etc. and use `std::os::raw::c_long` and friends on
// the Rust side. // the Rust side.
// //
// What's up with the long prefix? The "rb_" part is to appease `make leaked-globals` // What's up with the long prefix? Even though we build with `-fvisibility=hidden`
// which runs on upstream CI. The rationale for the check is unclear to Alan as // we are sometimes a static library where the option doesn't prevent name collision.
// we build with `-fvisibility=hidden` so only explicitly marked functions end
// up as public symbols in libruby.so. Perhaps the check is for the static
// libruby and or general namspacing hygiene? Alan admits his bias towards ELF
// platforms and newer compilers.
//
// The "_yjit_" part is for trying to be informative. We might want different // The "_yjit_" part is for trying to be informative. We might want different
// suffixes for symbols meant for Rust and symbols meant for broader CRuby. // suffixes for symbols meant for Rust and symbols meant for broader CRuby.