From 40d7c9c18b024f234f5fdd5c51fb843d9c229efc Mon Sep 17 00:00:00 2001 From: tmm1 Date: Tue, 10 Dec 2013 06:58:48 +0000 Subject: [PATCH] gc.c: speed up RGENGC_CHECK_MODE by removing unncessary check * gc.c (reflist_add): revert changes from r44109. it is unnecessary after r44113 * gc.c (allrefs_i): fix whitespace * gc.c (allrefs_roots_i): fix whitespace git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@44114 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 7 +++++++ gc.c | 14 ++++---------- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6db397cb24..9c623b89fc 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +Tue Dec 10 15:56:48 2013 Aman Gupta + + * gc.c (reflist_add): revert changes from r44109. it is unnecessary + after r44113 + * gc.c (allrefs_i): fix whitespace + * gc.c (allrefs_roots_i): fix whitespace + Tue Dec 10 15:46:03 2013 Koichi Sasada * gc.c (allrefs_add): push obj only if allrefs table doesn't have diff --git a/gc.c b/gc.c index 53af182034..bef72b0ece 100644 --- a/gc.c +++ b/gc.c @@ -4165,21 +4165,15 @@ reflist_destruct(struct reflist *refs) xfree(refs); } -static int +static void reflist_add(struct reflist *refs, VALUE obj) { - int i = 0; if (refs->pos == refs->size) { refs->size *= 2; SIZED_REALLOC_N(refs->list, VALUE, refs->size, refs->size/2); } - for (i=0; ipos; i++) - if (refs->list[i] == obj) - return 0; /* already exists */ - refs->list[refs->pos++] = obj; - return 1; /* added */ } static void @@ -4248,7 +4242,7 @@ allrefs_i(VALUE obj, void *ptr) if (allrefs_add(data, obj)) { push_mark_stack(&data->objspace->mark_stack, obj); -} + } } static void @@ -4259,8 +4253,8 @@ allrefs_roots_i(VALUE obj, void *ptr) data->root_obj = MAKE_ROOTSIG(data->category); if (allrefs_add(data, obj)) { - push_mark_stack(&data->objspace->mark_stack, obj); -} + push_mark_stack(&data->objspace->mark_stack, obj); + } } static st_table *