From 3dde9c1b436e2e03da70306f7e5d08d85c9d3ab0 Mon Sep 17 00:00:00 2001 From: Nobuyoshi Nakada Date: Sun, 28 Jan 2024 12:00:26 +0900 Subject: [PATCH] Extract continue-on-error condition to the matrix [ci skip] --- .github/workflows/yjit-macos.yml | 1 + .github/workflows/yjit-ubuntu.yml | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/yjit-macos.yml b/.github/workflows/yjit-macos.yml index 11e200a619..93bbb4d93e 100644 --- a/.github/workflows/yjit-macos.yml +++ b/.github/workflows/yjit-macos.yml @@ -119,6 +119,7 @@ jobs: TESTS: ${{ matrix.test_task == 'check' && matrix.skipped_tests || '' }} TEST_BUNDLED_GEMS_ALLOW_FAILURES: '' PRECHECK_BUNDLED_GEMS: 'no' + continue-on-error: ${{ matrix.continue-on-test_task || false }} - name: make skipped tests run: | diff --git a/.github/workflows/yjit-ubuntu.yml b/.github/workflows/yjit-ubuntu.yml index 7998e6b2e9..437f3d5339 100644 --- a/.github/workflows/yjit-ubuntu.yml +++ b/.github/workflows/yjit-ubuntu.yml @@ -109,6 +109,7 @@ jobs: - test_task: 'yjit-bench' configure: '--enable-yjit=dev' yjit_bench_opts: '--yjit-stats' + continue-on-test_task: true env: GITPULLOPTIONS: --no-tags origin ${{ github.ref }} @@ -173,7 +174,7 @@ jobs: PRECHECK_BUNDLED_GEMS: 'no' SYNTAX_SUGGEST_TIMEOUT: '5' YJIT_BINDGEN_DIFF_OPTS: '--exit-code' - continue-on-error: ${{ matrix.test_task == 'yjit-bench' }} + continue-on-error: ${{ matrix.continue-on-test_task || false }} - name: Show ${{ github.event.pull_request.base.ref }} GitHub URL for yjit-bench comparison run: echo "https://github.com/${BASE_REPO}/commit/${BASE_SHA}"