From 3dc313a239787007afdcad8cfaff6f32c3f0dd28 Mon Sep 17 00:00:00 2001 From: Aaron Patterson Date: Mon, 3 Aug 2020 09:22:52 -0700 Subject: [PATCH] Don't pin objects if we're just walking the heap Walking the heap can inadvertently pin objects. Only mark the object's pin bit if the mark_func_data pointer is NULL (similar to the mark bits) --- gc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gc.c b/gc.c index 03649a213d..22972dfc80 100644 --- a/gc.c +++ b/gc.c @@ -5313,7 +5313,9 @@ gc_pin(rb_objspace_t *objspace, VALUE obj) { GC_ASSERT(is_markable_object(objspace, obj)); if (UNLIKELY(objspace->flags.during_compacting)) { - MARK_IN_BITMAP(GET_HEAP_PINNED_BITS(obj), obj); + if (LIKELY(objspace->mark_func_data == NULL)) { + MARK_IN_BITMAP(GET_HEAP_PINNED_BITS(obj), obj); + } } }