1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rb_mod_const_get: do not goto into a branch

Browse Source 
I'm not necessarily against every goto in general, but jumping into a
branch is definitely a bad idea.  Better refactor.
This commit is contained in:
卜部昌平 2020-06-16 10:50:53 +09:00
parent 1f6e74106f
commit 3b8d9badab
Notes: git 2020-06-29 11:06:58 +09:00 
Merged: https://github.com/ruby/ruby/pull/3247
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
object.c
View File

@ -2504,8 +2504,7 @@ rb_mod_const_get(int argc, VALUE *argv, VALUE mod)
pend = path + RSTRING_LEN(name); pend = path + RSTRING_LEN(name);
if (p >= pend || !*p) { if (p >= pend || !*p) {
wrong_name: goto wrong_name;
rb_name_err_raise(wrong_constant_name, mod, name);
} }
if (p + 2 < pend && p[0] == ':' && p[1] == ':') { if (p + 2 < pend && p[0] == ':' && p[1] == ':') {
@ -2572,6 +2571,9 @@ rb_mod_const_get(int argc, VALUE *argv, VALUE mod)
} }
return mod; return mod;
wrong_name:
rb_name_err_raise(wrong_constant_name, mod, name);
} }
/* /*