1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

singleton_class_of: do not goto into a branch

Browse Source 
I'm not necessarily against every goto in general, but jumping into a
branch is definitely a bad idea.  Better refactor.
This commit is contained in:
卜部昌平 2020-06-11 13:53:16 +09:00
parent 86e3d63772
commit 3a3728e4b3
Notes: git 2020-06-29 11:07:14 +09:00 
Merged: https://github.com/ruby/ruby/pull/3247
1 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
class.c
View File

@ -1778,26 +1778,25 @@ singleton_class_of(VALUE obj)
{ {
VALUE klass; VALUE klass;
if (FIXNUM_P(obj) || FLONUM_P(obj) || STATIC_SYM_P(obj)) { switch (TYPE(obj)) {
no_singleton: case T_FIXNUM:
case T_BIGNUM:
case T_FLOAT:
case T_SYMBOL:
rb_raise(rb_eTypeError, "can't define singleton"); rb_raise(rb_eTypeError, "can't define singleton");
}
if (SPECIAL_CONST_P(obj)) { case T_FALSE:
case T_TRUE:
case T_NIL:
klass = special_singleton_class_of(obj); klass = special_singleton_class_of(obj);
if (NIL_P(klass)) if (NIL_P(klass))
rb_bug("unknown immediate %p", (void *)obj); rb_bug("unknown immediate %p", (void *)obj);
return klass; return klass;
}
else { case T_STRING:
switch (BUILTIN_TYPE(obj)) { if (FL_TEST_RAW(obj, RSTRING_FSTR)) {
case T_FLOAT: case T_BIGNUM: case T_SYMBOL: rb_raise(rb_eTypeError, "can't define singleton");
goto no_singleton; }
case T_STRING:
if (FL_TEST_RAW(obj, RSTRING_FSTR)) goto no_singleton;
break;
default:
break;
}
} }
klass = RBASIC(obj)->klass; klass = RBASIC(obj)->klass;