From 39edad0380ce78a354cb7aa7d90579e395c6f432 Mon Sep 17 00:00:00 2001 From: a_matsuda Date: Tue, 8 Nov 2016 20:25:44 +0000 Subject: [PATCH] Fix undefined method 'dump' for nil:NilClass (NoMethodError) Patch by: Dmitry Vorotilin (@route) Signed-off-by: Akira Matsuda closes #1475 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56681 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- lib/net/http/response.rb | 4 +++- test/net/http/test_httpresponse.rb | 16 ++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/lib/net/http/response.rb b/lib/net/http/response.rb index e2964c41a1..1351d7b2d2 100644 --- a/lib/net/http/response.rb +++ b/lib/net/http/response.rb @@ -117,7 +117,9 @@ class Net::HTTPResponse end def error! #:nodoc: - raise error_type().new(@code + ' ' + @message.dump, self) + message = @code + message += ' ' + @message.dump if @message + raise error_type().new(message, self) end def error_type #:nodoc: diff --git a/test/net/http/test_httpresponse.rb b/test/net/http/test_httpresponse.rb index a494b7fb85..a67add7c88 100644 --- a/test/net/http/test_httpresponse.rb +++ b/test/net/http/test_httpresponse.rb @@ -385,6 +385,22 @@ EOS assert_equal(nil, res.message) end + def test_raises_exception_with_missing_reason + io = dummy_io(<