1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[rubygems/rubygems] Reduce confusion about domains used for testing

Browse Source 
Sometimes security reports believe they have found a vulnerability
because they find a domain we don't own being used in the rubygems
repository. Though there is nothing vulnerable about using 'fake'
domains in tests when they are never hit, it nonetheless reduces
confusion for everyone if we constrain our test domains to domains
we actually own and control.

https://github.com/rubygems/rubygems/commit/e77ebbe2fc
This commit is contained in:
Martin Emde 2025-02-17 09:57:28 -08:00 committed by Hiroshi SHIBATA
parent 507de2226b
commit 39960cd748
3 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
spec/bundler/bundler/settings_spec.rb
View File

@ -200,7 +200,7 @@ that would suck --ehhh=oh geez it looks like i might have broken bundler somehow
end end
context "with a configured mirror" do context "with a configured mirror" do
let(:mirror_uri) { Gem::URI("https://rubygems-mirror.org/") } let(:mirror_uri) { Gem::URI("https://example-mirror.rubygems.org/") }
before { settings.set_local "mirror.https://rubygems.org/", mirror_uri.to_s } before { settings.set_local "mirror.https://rubygems.org/", mirror_uri.to_s }
@ -277,12 +277,12 @@ that would suck --ehhh=oh geez it looks like i might have broken bundler somehow
end end
it "normalizes HTTP URIs in mirror configuration" do it "normalizes HTTP URIs in mirror configuration" do
settings.set_local "mirror.http://rubygems.org", "http://rubygems-mirror.org" settings.set_local "mirror.http://rubygems.org", "http://example-mirror.rubygems.org"
expect(settings.all).to include("mirror.http://rubygems.org/") expect(settings.all).to include("mirror.http://rubygems.org/")
end end
it "normalizes HTTPS URIs in mirror configuration" do it "normalizes HTTPS URIs in mirror configuration" do
settings.set_local "mirror.https://rubygems.org", "http://rubygems-mirror.org" settings.set_local "mirror.https://rubygems.org", "http://example-mirror.rubygems.org"
expect(settings.all).to include("mirror.https://rubygems.org/") expect(settings.all).to include("mirror.https://rubygems.org/")
end end
@ -297,9 +297,9 @@ that would suck --ehhh=oh geez it looks like i might have broken bundler somehow
end end
it "reads older keys without trailing slashes" do it "reads older keys without trailing slashes" do
settings.set_local "mirror.https://rubygems.org", "http://rubygems-mirror.org" settings.set_local "mirror.https://rubygems.org", "http://example-mirror.rubygems.org"
expect(settings.mirror_for("https://rubygems.org/")).to eq( expect(settings.mirror_for("https://rubygems.org/")).to eq(
Gem::URI("http://rubygems-mirror.org/") Gem::URI("http://example-mirror.rubygems.org/")
) )
end end
@ -323,8 +323,8 @@ that would suck --ehhh=oh geez it looks like i might have broken bundler somehow
end end
it "converts older keys without trailing slashes and double underscore" do it "converts older keys without trailing slashes and double underscore" do
config("BUNDLE_MIRROR__HTTPS://RUBYGEMS.ORG" => "http://rubygems-mirror.org") config("BUNDLE_MIRROR__HTTPS://RUBYGEMS.ORG" => "http://example-mirror.rubygems.org")
expect(settings["mirror.https://rubygems.org/"]).to eq("http://rubygems-mirror.org") expect(settings["mirror.https://rubygems.org/"]).to eq("http://example-mirror.rubygems.org")
end end
it "ignores commented out keys" do it "ignores commented out keys" do
@ -347,8 +347,8 @@ that would suck --ehhh=oh geez it looks like i might have broken bundler somehow
end end
it "reads newer keys format properly" do it "reads newer keys format properly" do
config("BUNDLE_MIRROR__HTTPS://RUBYGEMS__ORG/" => "http://rubygems-mirror.org") config("BUNDLE_MIRROR__HTTPS://RUBYGEMS__ORG/" => "http://example-mirror.rubygems.org")
expect(settings["mirror.https://rubygems.org/"]).to eq("http://rubygems-mirror.org") expect(settings["mirror.https://rubygems.org/"]).to eq("http://example-mirror.rubygems.org")
end end
end end
end end

8
spec/bundler/bundler/source/rubygems/remote_spec.rb
View File

@ -106,8 +106,8 @@ RSpec.describe Bundler::Source::Rubygems::Remote do
context "when a mirror with inline credentials is configured for the URI" do context "when a mirror with inline credentials is configured for the URI" do
let(:uri) { Gem::URI("https://rubygems.org/") } let(:uri) { Gem::URI("https://rubygems.org/") }
let(:mirror_uri_with_auth) { Gem::URI("https://username:password@rubygems-mirror.org/") } let(:mirror_uri_with_auth) { Gem::URI("https://username:password@example-mirror.rubygems.org/") }
let(:mirror_uri_no_auth) { Gem::URI("https://rubygems-mirror.org/") } let(:mirror_uri_no_auth) { Gem::URI("https://example-mirror.rubygems.org/") }
before { Bundler.settings.temporary("mirror.https://rubygems.org/" => mirror_uri_with_auth.to_s) } before { Bundler.settings.temporary("mirror.https://rubygems.org/" => mirror_uri_with_auth.to_s) }
@ -132,8 +132,8 @@ RSpec.describe Bundler::Source::Rubygems::Remote do
context "when a mirror with configured credentials is configured for the URI" do context "when a mirror with configured credentials is configured for the URI" do
let(:uri) { Gem::URI("https://rubygems.org/") } let(:uri) { Gem::URI("https://rubygems.org/") }
let(:mirror_uri_with_auth) { Gem::URI("https://#{credentials}@rubygems-mirror.org/") } let(:mirror_uri_with_auth) { Gem::URI("https://#{credentials}@example-mirror.rubygems.org/") }
let(:mirror_uri_no_auth) { Gem::URI("https://rubygems-mirror.org/") } let(:mirror_uri_no_auth) { Gem::URI("https://example-mirror.rubygems.org/") }
before do before do
Bundler.settings.temporary("mirror.https://rubygems.org/" => mirror_uri_no_auth.to_s) Bundler.settings.temporary("mirror.https://rubygems.org/" => mirror_uri_no_auth.to_s)

4
spec/bundler/bundler/yaml_serializer_spec.rb
View File

@ -112,10 +112,10 @@ RSpec.describe Bundler::YAMLSerializer do
it "handles colon in key/value" do it "handles colon in key/value" do
yaml = <<~YAML yaml = <<~YAML
BUNDLE_MIRROR__HTTPS://RUBYGEMS__ORG/: http://rubygems-mirror.org BUNDLE_MIRROR__HTTPS://RUBYGEMS__ORG/: http://example-mirror.rubygems.org
YAML YAML
expect(serializer.load(yaml)).to eq("BUNDLE_MIRROR__HTTPS://RUBYGEMS__ORG/" => "http://rubygems-mirror.org") expect(serializer.load(yaml)).to eq("BUNDLE_MIRROR__HTTPS://RUBYGEMS__ORG/" => "http://example-mirror.rubygems.org")
end end
it "handles arrays inside hashes" do it "handles arrays inside hashes" do