From 393e577d31607c7cd2a2e953c185229083d96c2c Mon Sep 17 00:00:00 2001 From: charliesome Date: Mon, 28 Oct 2013 00:31:07 +0000 Subject: [PATCH] * vm.c: vm_clear_all_cache is not necessary now we use a 64 bit counter for global state version. * vm_insnhelper.h: ruby_vm_global_state_version overflow is unnecessary git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43444 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 7 +++++++ vm.c | 16 ---------------- vm_insnhelper.h | 2 -- 3 files changed, 7 insertions(+), 18 deletions(-) diff --git a/ChangeLog b/ChangeLog index 5ce9b1e82c..875ea68f7f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +Mon Oct 28 09:29:00 2013 Charlie Somerville + + * vm.c: vm_clear_all_cache is not necessary now we use a 64 bit counter + for global state version. + + * vm_insnhelper.h: ruby_vm_global_state_version overflow is unnecessary + Mon Oct 28 07:47:32 2013 Aman Gupta * vm_backtrace.c (rb_profile_frame_classpath): do not use rb_inspect diff --git a/vm.c b/vm.c index acae935446..80e13de1bd 100644 --- a/vm.c +++ b/vm.c @@ -106,22 +106,6 @@ rb_event_flag_t ruby_vm_event_flags; static void thread_free(void *ptr); -static void -vm_clear_all_inline_method_cache(void) -{ - /* TODO: Clear all inline cache entries in all iseqs. - How to iterate all iseqs in sweep phase? - rb_objspace_each_objects() doesn't work at sweep phase. - */ -} - -static void -vm_clear_all_cache() -{ - vm_clear_all_inline_method_cache(); - ruby_vm_global_state_version = 1; -} - void rb_vm_inc_const_missing_count(void) { diff --git a/vm_insnhelper.h b/vm_insnhelper.h index 73e88e5a42..1c0d046587 100644 --- a/vm_insnhelper.h +++ b/vm_insnhelper.h @@ -263,9 +263,7 @@ enum vm_regan_acttype { #define GET_VM_STATE_VERSION() (ruby_vm_global_state_version) #define INC_VM_STATE_VERSION() do { \ ruby_vm_global_state_version = (ruby_vm_global_state_version + 1); \ - if (ruby_vm_global_state_version == 0) vm_clear_all_cache(); \ } while (0) -static void vm_clear_all_cache(void); static VALUE make_no_method_exception(VALUE exc, const char *format, VALUE obj, int argc, const VALUE *argv);