1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

YJIT: Add a few asm comments (#7105)

Browse Source 
* YJIT: Add a few asm comments

* YJIT: Clarify exiting insns

* YJIT: Fix cargo test
This commit is contained in:
Takashi Kokubun 2023-01-11 11:12:15 -08:00 committed by GitHub
parent ad5ab0c3ea
commit 3642006872
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
Notes: git 2023-01-11 19:12:37 +00:00 
Merged-By: k0kubun <takashikkbn@gmail.com>
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
yjit/src/codegen.rs
View File

@ -387,7 +387,11 @@ fn gen_code_for_exit_from_stub(ocb: &mut OutlinedCb) -> CodePtr {
/// Generate an exit to return to the interpreter
fn gen_exit(exit_pc: *mut VALUE, ctx: &Context, asm: &mut Assembler) {
asm.comment("exit to interpreter");
#[cfg(all(feature = "disasm", not(test)))]
{
let opcode = unsafe { rb_vm_insn_addr2opcode((*exit_pc).as_ptr()) };
asm.comment(&format!("exit to interpreter on {}", insn_name(opcode as usize)));
}
// Generate the code to exit to the interpreters
// Write the adjusted SP back into the CFP
@ -769,7 +773,7 @@ pub fn gen_single_block(
gen_counter_incr!(asm, exec_instruction);
// Add a comment for the name of the YARV instruction
asm.comment(&insn_name(opcode));
asm.comment(&format!("Insn: {}", insn_name(opcode)));
// If requested, dump instructions for debugging
if get_option!(dump_insns) {
@ -4776,6 +4780,7 @@ fn gen_return_branch(
match shape {
BranchShape::Next0 | BranchShape::Next1 => unreachable!(),
BranchShape::Default => {
asm.comment("update cfp->jit_return");
asm.mov(Opnd::mem(64, CFP, RUBY_OFFSET_CFP_JIT_RETURN), Opnd::const_ptr(target0.raw_ptr()));
}
}

1
yjit/src/core.rs
View File

@ -2126,6 +2126,7 @@ pub fn defer_compilation(
set_branch_target(0, blockid, &next_ctx, &branch_rc, &mut branch, ocb);
// Call the branch generation function
asm.comment("defer_compilation");
asm.mark_branch_start(&branch_rc);
if let Some(dst_addr) = branch.get_target_address(0) {
gen_jump_branch(asm, dst_addr, None, BranchShape::Default);