1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Bug #20755] Frozen string should not be writable via IO::Buffer

Browse Source
This commit is contained in:
Nobuyoshi Nakada 2024-09-30 22:49:09 +09:00
parent 3ebc85e240
commit 35e124832e
No known key found for this signature in database
GPG Key ID: 3582D74E1FEE4465
Notes: git 2024-10-01 10:59:57 +00:00 
Merged: https://github.com/ruby/ruby/pull/11738
2 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
io_buffer.c
View File

@ -843,7 +843,8 @@ rb_io_buffer_get_bytes(VALUE self, void **base, size_t *size)
static inline void
io_buffer_get_bytes_for_writing(struct rb_io_buffer *buffer, void **base, size_t *size)
{
if (buffer->flags & RB_IO_BUFFER_READONLY) {
if (buffer->flags & RB_IO_BUFFER_READONLY ||
(!NIL_P(buffer->source) && OBJ_FROZEN(buffer->source))) {
rb_raise(rb_eIOBufferAccessError, "Buffer is not writable!");
}

25
test/ruby/test_io_buffer.rb
View File

@ -248,6 +248,31 @@ class TestIOBuffer < Test::Unit::TestCase
assert_equal "Hello World", hello
end
def test_transfer
hello = %w"Hello World".join(" ")
buffer = IO::Buffer.for(hello)
transferred = buffer.transfer
assert_equal "Hello World", transferred.get_string
assert_predicate buffer, :null?
assert_raise IO::Buffer::AccessError do
transferred.set_string("Goodbye")
end
assert_equal "Hello World", hello
end
def test_transfer_in_block
hello = %w"Hello World".join(" ")
buffer = IO::Buffer.for(hello, &:transfer)
assert_equal "Hello World", buffer.get_string
buffer.set_string("Ciao!")
assert_equal "Ciao! World", hello
hello.freeze
assert_raise IO::Buffer::AccessError do
buffer.set_string("Hola")
end
assert_equal "Ciao! World", hello
end
def test_locked
buffer = IO::Buffer.new(128, IO::Buffer::INTERNAL|IO::Buffer::LOCKED)