Refine TestSocket_TCPSocket#test_initialize_failure

* Use `assert_raise_kind_of` instead of `rescue` and `flunk`.
* Use `assert_include` for the pattern that may contain regexp meta
  characters.
This commit is contained in:
Nobuyoshi Nakada 2025-03-15 15:52:49 +09:00
parent 29c0ca58c2
commit 35920f7a44
No known key found for this signature in database
GPG Key ID: 3582D74E1FEE4465

View File

@ -49,16 +49,14 @@ class TestSocket_TCPSocket < Test::Unit::TestCase
server_addr = '127.0.0.1'
server_port = 80
begin
e = assert_raise_kind_of(SystemCallError) do
# Since client_addr is not an IP address of this host,
# bind() in TCPSocket.new should fail as EADDRNOTAVAIL.
t = TCPSocket.new(server_addr, server_port, client_addr, client_port)
flunk "expected SystemCallError"
rescue SystemCallError => e
assert_match "for \"#{client_addr}\" port #{client_port}", e.message
ensure
t&.close
end
ensure
t.close if t && !t.closed?
assert_include e.message, "for \"#{client_addr}\" port #{client_port}"
end
def test_initialize_resolv_timeout