1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[rubygems/rubygems] Apply suggestions from code review

Browse Source 
https://github.com/rubygems/rubygems/commit/7c634ecd72
This commit is contained in:
Samuel Giddins 2024-12-04 15:49:01 -08:00 committed by git
parent 7daf85bdf2
commit 305318edbb
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/rubygems/source/git.rb
View File

@ -93,18 +93,18 @@ class Gem::Source::Git < Gem::Source
return false unless File.exist? repo_cache_dir return false unless File.exist? repo_cache_dir
unless File.exist? install_dir unless File.exist? install_dir
system git, "clone", "--quiet", "--no-checkout", system git_command, "clone", "--quiet", "--no-checkout",
repo_cache_dir, install_dir repo_cache_dir, install_dir
end end
Dir.chdir install_dir do Dir.chdir install_dir do
system git, "fetch", "--quiet", "--force", "--tags", install_dir system git_command, "fetch", "--quiet", "--force", "--tags", install_dir
success = system git, "reset", "--quiet", "--hard", rev_parse success = system git_command, "reset", "--quiet", "--hard", rev_parse
if @need_submodules if @need_submodules
require "open3" require "open3"
_, status = Open3.capture2e(git, "submodule", "update", "--quiet", "--init", "--recursive") _, status = Open3.capture2e(git_command, "submodule", "update", "--quiet", "--init", "--recursive")
success &&= status.success? success &&= status.success?
end end
@ -121,11 +121,11 @@ class Gem::Source::Git < Gem::Source
if File.exist? repo_cache_dir if File.exist? repo_cache_dir
Dir.chdir repo_cache_dir do Dir.chdir repo_cache_dir do
system git, "fetch", "--quiet", "--force", "--tags", system git_command, "fetch", "--quiet", "--force", "--tags",
@repository, "refs/heads/*:refs/heads/*" @repository, "refs/heads/*:refs/heads/*"
end end
else else
system git, "clone", "--quiet", "--bare", "--no-hardlinks", system git_command, "clone", "--quiet", "--bare", "--no-hardlinks",
@repository, repo_cache_dir @repository, repo_cache_dir
end end
end end