1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Started refactoring opt_send_without_block with codegen-time checks

Browse Source
This commit is contained in:
Maxime Chevalier-Boisvert 2020-10-15 15:15:31 -04:00 committed by Alan Wu
parent 32a66b99f6
commit 2cb376a53f
1 changed files with 27 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
ujit_compile.c
View File

@ -463,13 +463,16 @@ gen_opt_minus(codeblock_t* cb, codeblock_t* ocb, ctx_t* ctx)
bool bool
gen_opt_send_without_block(codeblock_t* cb, codeblock_t* ocb, ctx_t* ctx) gen_opt_send_without_block(codeblock_t* cb, codeblock_t* ocb, ctx_t* ctx)
{ {
// Definitions relevant to the call cache are in vm_callinfo.h
struct rb_call_data * cd = (struct rb_call_data *)ctx_get_arg(ctx, 0); struct rb_call_data * cd = (struct rb_call_data *)ctx_get_arg(ctx, 0);
int32_t argc = (int32_t)vm_ci_argc(cd->ci); int32_t argc = (int32_t)vm_ci_argc(cd->ci);
const struct rb_callcache *cc = cd->cc; const struct rb_callcache *cc = cd->cc;
// Callee method ID // Callee method ID
ID mid = vm_ci_mid(cd->ci); ID mid = vm_ci_mid(cd->ci);
//fprintf(stderr, "jitting call to \"%s\", argc: %lu\n", rb_id2name(mid), argc);
//printf("jitting call to \"%s\", argc: %lu\n", rb_id2name(mid), argc);
// Don't JIT calls with keyword splat // Don't JIT calls with keyword splat
if (vm_ci_flag(cd->ci) & VM_CALL_KW_SPLAT) if (vm_ci_flag(cd->ci) & VM_CALL_KW_SPLAT)
@ -477,12 +480,29 @@ gen_opt_send_without_block(codeblock_t* cb, codeblock_t* ocb, ctx_t* ctx)
return false; return false;
} }
// Don't jit calls that aren't simple // Don't JIT calls that aren't simple
if (!(vm_ci_flag(cd->ci) & VM_CALL_ARGS_SIMPLE)) if (!(vm_ci_flag(cd->ci) & VM_CALL_ARGS_SIMPLE))
{ {
return false; return false;
} }
// Don't JIT if the inline cache is not set
if (cd->cc == vm_cc_empty())
{
//printf("call cache is empty\n");
return false;
}
/*
// Don't JIT if this is not a C call
if (cd->cc->call_ != vm_call_cfunc_with_frame)
{
return false;
}
*/
// TODO: stop if the inline cache isn't filled // TODO: stop if the inline cache isn't filled
// TODO: stop if this isn't a C call // TODO: stop if this isn't a C call
@ -496,6 +516,8 @@ gen_opt_send_without_block(codeblock_t* cb, codeblock_t* ocb, ctx_t* ctx)
return false; return false;
/* /*
@ -528,12 +550,13 @@ gen_opt_send_without_block(codeblock_t* cb, codeblock_t* ocb, ctx_t* ctx)
mov(cb, recv_opnd, RDX); mov(cb, recv_opnd, RDX);
//print_int(cb, recv_opnd);
// Pointer to the klass field of the receiver // Pointer to the klass field of the receiver
x86opnd_t klass_opnd = mem_opnd(64, RDX, offsetof(struct RBasic, klass)); x86opnd_t klass_opnd = mem_opnd(64, RDX, offsetof(struct RBasic, klass));
// IDEA: Aaron suggested we could possibly treat a changed
// class pointer as a cache miss
// Check if we have a cache hit
cmp(cb, R9, klass_opnd); cmp(cb, R9, klass_opnd);
jne_ptr(cb, side_exit); jne_ptr(cb, side_exit);
//print_int(cb, klass_opnd); //print_int(cb, klass_opnd);