1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ractor_wakeup was broken when compiled with USE_RUBY_DEBUG_LOG

Browse Source 
The `ractor_wakeup` function takes an optional `th` argument, so it can be NULL.
There is a macro call to RUBY_DEBUG_LOG that dereferences `th` without checking
if it's NULL first. To fix this, we never dereference `th` in this macro call.
This commit is contained in:
Luke Gruber 2025-05-23 13:53:00 -04:00 committed by John Hawthorn
parent 75b92c5cd6
commit 2b5a674440
Notes: git 2025-05-23 23:03:02 +00:00 
Merged: https://github.com/ruby/ruby/pull/13431
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ractor.c
View File

@ -576,9 +576,8 @@ ractor_wakeup(rb_ractor_t *r, rb_thread_t *th /* can be NULL */, enum rb_ractor_
{ {
ASSERT_ractor_locking(r); ASSERT_ractor_locking(r);
RUBY_DEBUG_LOG("r:%u wait_by:%s -> wait:%s wakeup:%s", RUBY_DEBUG_LOG("r:%u wait:%s wakeup:%s",
rb_ractor_id(r), rb_ractor_id(r),
wait_status_str(th->ractor_waiting.wait_status),
wait_status_str(wait_status), wait_status_str(wait_status),
wakeup_status_str(wakeup_status)); wakeup_status_str(wakeup_status));