1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/error_highlight] Fix error with prism when method given no arguments

Browse Source 
such as:

  p = Proc.new

This now matches the RubyVM::AbstractSyntaxTree behavior, which is
not to highlight anything.

https://github.com/ruby/error_highlight/commit/d5c592a1ba
This commit is contained in:
Luke Gruber 2024-09-17 08:34:29 -04:00 committed by git
parent 414a848cc6
commit 2a0ee408af
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/error_highlight/base.rb
View File

@ -700,6 +700,9 @@ module ErrorHighlight
# foo 42 # foo 42
# ^^ # ^^
def prism_spot_call_for_args def prism_spot_call_for_args
# Disallow highlighting arguments if there are no arguments.
return if @node.arguments.nil?
# Explicitly turn off foo.() syntax because error_highlight expects this # Explicitly turn off foo.() syntax because error_highlight expects this
# to not work. # to not work.
return nil if @node.name == :call && @node.message_loc.nil? return nil if @node.name == :call && @node.message_loc.nil?

9
test/error_highlight/test_error_highlight.rb
View File

@ -197,6 +197,15 @@ undefined method `foo' for #{ NIL_RECV_MESSAGE }
end end
end end
def test_CALL_arg_7
assert_error_message(ArgumentError, <<~END) do
tried to create Proc object without a block (ArgumentError)
END
Proc.new
end
end
def test_QCALL_1 def test_QCALL_1
assert_error_message(NoMethodError, <<~END) do assert_error_message(NoMethodError, <<~END) do
undefined method `foo' for #{ ONE_RECV_MESSAGE } undefined method `foo' for #{ ONE_RECV_MESSAGE }