1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

skip if DidYouMean.formatter= is not defined

Browse Source 
ruby/test_default_gems.rb can define empty `DidYouMean` module
because of the following line (second require) in the
`lib/did_you_mean/did_you_mean.gemspec`:

```ruby
begin
  require_relative "lib/did_you_mean/version"
rescue LoadError # Fallback to load version file in ruby core repository
  require_relative "version"
end
```

It defines only `::DidYouMean::VERSION`.

However, in the `test/ruby/test_patten_matching.rb` assumes that
if `defined?(DidYouMean)` is true, then there is a method `DidYouMean.formatter=`
and this assumption fails all tests in `test/ruby/test_patten_matching.rb` if
there is only a `::DidYouMean::VERSION`.

To reproduce the failures, we need to repeat the following command:

`make test-all TESTS='-v ruby/test_default_gems.rb ruby/pattern_matching'`

(because the ruby/test_default_gems.rb should be run before the ruby/pattern_matching`)

This patch introduces more strict gurds.
This commit is contained in:
Koichi Sasada 2023-04-16 03:58:57 +09:00
parent 52449b5b75
commit 29e01c6f5f
Notes: git 2023-04-16 00:27:26 +00:00 
Merged: https://github.com/ruby/ruby/pull/7722
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/ruby/test_pattern_matching.rb
View File

@ -9,14 +9,14 @@ class TestPatternMatching < Test::Unit::TestCase
end end
def setup def setup
if defined?(DidYouMean) if defined?(DidYouMean.formatter=nil)
@original_formatter = DidYouMean.formatter @original_formatter = DidYouMean.formatter
DidYouMean.formatter = NullFormatter.new DidYouMean.formatter = NullFormatter.new
end end
end end
def teardown def teardown
if defined?(DidYouMean) if defined?(DidYouMean.formatter=nil)
DidYouMean.formatter = @original_formatter DidYouMean.formatter = @original_formatter
end end
end end