From 27f2c267fd667045ed7288d91076508618cfe0a8 Mon Sep 17 00:00:00 2001 From: glass Date: Wed, 6 Nov 2013 12:09:31 +0000 Subject: [PATCH] * array.c (rb_ary_reverse): use RARRAY_PTR_USE(). git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43556 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 4 ++++ array.c | 12 +++++++----- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index 1ab0d894d6..3bc5e71194 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +Wed Nov 6 21:05:20 2013 Masaki Matsushita + + * array.c (rb_ary_reverse): use RARRAY_PTR_USE(). + Wed Nov 6 19:30:44 2013 Masaya Tarui * common.mk (help): add texts about gcbench. diff --git a/array.c b/array.c index e708cb13dd..2a85772c97 100644 --- a/array.c +++ b/array.c @@ -2176,13 +2176,15 @@ ary_reverse(VALUE *p1, VALUE *p2) VALUE rb_ary_reverse(VALUE ary) { - VALUE *p1, *p2; + VALUE *p2; + long len = RARRAY_LEN(ary); rb_ary_modify(ary); - if (RARRAY_LEN(ary) > 1) { - p1 = RARRAY_PTR(ary); - p2 = p1 + RARRAY_LEN(ary) - 1; /* points last item */ - ary_reverse(p1, p2); + if (len > 1) { + RARRAY_PTR_USE(ary, p1, { + p2 = p1 + len - 1; /* points last item */ + ary_reverse(p1, p2); + }); /* WB: no new reference */ } return ary; }