1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Optimize rb_must_asciicompat

Browse Source 
While profiling `strscan`, I noticed `rb_must_asciicompat` was quite
slow, as more than 5% of the benchmark was spent in it: https://share.firefox.dev/49bOcTn

By checking for the common 3 ASCII compatible encoding index first,
we can skip a lot of expensive operations in the happy path.
This commit is contained in:
Jean Boussier 2024-11-27 10:32:57 +01:00
parent 43b059b6a3
commit 26d020cb6e
Notes: git 2024-11-27 13:50:30 +00:00 
Merged: https://github.com/ruby/ruby/pull/12180
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
string.c
View File

@ -2691,10 +2691,17 @@ str_discard(VALUE str)
void
rb_must_asciicompat(VALUE str)
{
rb_encoding *enc = rb_enc_get(str);
if (!enc) {
int encindex = rb_enc_get_index(str);
if (RB_UNLIKELY(encindex == -1)) {
rb_raise(rb_eTypeError, "not encoding capable object");
}
if (RB_LIKELY(str_encindex_fastpath(encindex))) {
return;
}
rb_encoding *enc = rb_enc_from_index(encindex);
if (!rb_enc_asciicompat(enc)) {
rb_raise(rb_eEncCompatError, "ASCII incompatible encoding: %s", rb_enc_name(enc));
}