From 24d02cd4859ea3cee3b9dfaca196c7b34c5686a4 Mon Sep 17 00:00:00 2001 From: eileencodes Date: Wed, 17 Jan 2024 11:36:45 -0500 Subject: [PATCH] [Prism] Implement defined? for PM_WHILE_NODE Ruby code: ```ruby defined?(while a != 1; end) ``` Instructions: ``` "********* Ruby *************" == disasm: #@:1 (1,0)-(59,16)> 0000 putobject "expression" ( 59)[Li] 0002 leave "********* PRISM *************" == disasm: #@:58 (58,0)-(58,16)> 0000 putobject "expression" ( 58)[Li] 0002 leave ``` Related: ruby/prism#2188 --- prism_compile.c | 1 + test/ruby/test_compile_prism.rb | 1 + 2 files changed, 2 insertions(+) diff --git a/prism_compile.c b/prism_compile.c index 70faae0e0f..729e82a24a 100644 --- a/prism_compile.c +++ b/prism_compile.c @@ -2571,6 +2571,7 @@ pm_compile_defined_expr0(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *co case PM_SOURCE_LINE_NODE: case PM_STRING_NODE: case PM_SYMBOL_NODE: + case PM_WHILE_NODE: case PM_X_STRING_NODE: dtype = DEFINED_EXPR; break; diff --git a/test/ruby/test_compile_prism.rb b/test/ruby/test_compile_prism.rb index 6972938573..7bb94ecb8b 100644 --- a/test/ruby/test_compile_prism.rb +++ b/test/ruby/test_compile_prism.rb @@ -260,6 +260,7 @@ module Prism assert_prism_eval("defined?(module M; end)") assert_prism_eval("defined?(1.2r)") assert_prism_eval("defined?(class << self; end)") + assert_prism_eval("defined?(while a != 1; end)") end def test_GlobalVariableReadNode