1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/openssl] test/openssl/test_pkey.rb: allow failures in test_s_generate_parameters

Browse Source 
Commit https://github.com/ruby/openssl/commit/f2e2a5e5ed8e ("test/openssl/test_pkey.rb: allow failures in
test_s_generate_parameters", 2022-12-23) was completely bogus. The
problem in OpenSSL 3.0.0-3.0.5 is that errors from the callback are
sometimes silently suppressed.

https://github.com/ruby/openssl/commit/ccc1594492
This commit is contained in:
Kazuki Yamaguchi 2022-12-24 02:02:13 +09:00 committed by Hiroshi SHIBATA
parent cea6951ecf
commit 24c9adcaeb
Notes: git 2022-12-26 06:09:41 +00:00 
Merged: https://github.com/ruby/ruby/pull/7025
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/openssl/test_pkey.rb
View File

@ -40,6 +40,11 @@ class OpenSSL::TestPKey < OpenSSL::PKeyTestCase
} }
# Parameter generation callback is called # Parameter generation callback is called
if openssl?(3, 0, 0, 0) && !openssl?(3, 0, 0, 6)
# Errors in BN_GENCB were not properly handled. This special pend is to
# suppress failures on Ubuntu 22.04, which uses OpenSSL 3.0.2.
pend "unstable test on OpenSSL 3.0.[0-5]"
end
cb_called = [] cb_called = []
assert_raise(RuntimeError) { assert_raise(RuntimeError) {
OpenSSL::PKey.generate_parameters("DSA") { |*args| OpenSSL::PKey.generate_parameters("DSA") { |*args|
@ -47,11 +52,6 @@ class OpenSSL::TestPKey < OpenSSL::PKeyTestCase
raise "exit!" if cb_called.size == 3 raise "exit!" if cb_called.size == 3
} }
} }
if !cb_called && openssl?(3, 0, 0) && !openssl?(3, 0, 6)
# Errors in BN_GENCB were not properly handled. This special pend is to
# suppress failures on Ubuntu 22.04, which uses OpenSSL 3.0.2.
pend "unstable test on OpenSSL 3.0.[0-5]"
end
assert_not_empty cb_called assert_not_empty cb_called
end end