1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bind_local_variable_get: do not goto into a branch

Browse Source 
I'm not necessarily against every goto in general, but jumping into a
branch is definitely a bad idea.  Better refactor.
This commit is contained in:
卜部昌平 2020-06-16 11:27:30 +09:00
parent 82ed66a75a
commit 2390a8bd2e
Notes: git 2020-06-29 11:06:55 +09:00 
Merged: https://github.com/ruby/ruby/pull/3247
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
proc.c
View File

@ -541,16 +541,16 @@ bind_local_variable_get(VALUE bindval, VALUE sym)
GetBindingPtr(bindval, bind); GetBindingPtr(bindval, bind);
env = VM_ENV_ENVVAL_PTR(vm_block_ep(&bind->block)); env = VM_ENV_ENVVAL_PTR(vm_block_ep(&bind->block));
if ((ptr = get_local_variable_ptr(&env, lid)) == NULL) { if ((ptr = get_local_variable_ptr(&env, lid)) != NULL) {
return *ptr;
}
sym = ID2SYM(lid); sym = ID2SYM(lid);
undefined: undefined:
rb_name_err_raise("local variable `%1$s' is not defined for %2$s", rb_name_err_raise("local variable `%1$s' is not defined for %2$s",
bindval, sym); bindval, sym);
} }
return *ptr;
}
/* /*
* call-seq: * call-seq:
* binding.local_variable_set(symbol, obj) -> obj * binding.local_variable_set(symbol, obj) -> obj