1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

* ext/bigdecimal/bigdecimal.c (GetVpValueWithPrec):

Browse Source 
treat 0.0 and -0.0 of floating-point numbers specially for an optimization
  and to correctly propagate its signbit to the result.
  [Bug #9214] [ruby-core:58858]

* test/bigdecimal/test_bigdecimal.rb: add tests case for the above change.

* test/bigdecimal/test_bigdecimal_util.rb: ditto.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@44021 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
mrkn 2013-12-05 16:34:59 +00:00
parent 8cffe06a04
commit 2308fb170e
4 changed files with 31 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ChangeLog
View File

@ -1,3 +1,14 @@
Thu Dec 6 01:27:00 2013 Kenta Murata <mrkn@mrkn.jp>
* ext/bigdecimal/bigdecimal.c (GetVpValueWithPrec):
treat 0.0 and -0.0 of floating-point numbers specially for an optimization
and to correctly propagate its signbit to the result.
[Bug #9214] [ruby-core:58858]
* test/bigdecimal/test_bigdecimal.rb: add tests case for the above change.
* test/bigdecimal/test_bigdecimal_util.rb: ditto.
Thu Dec 5 22:18:01 2013 Nobuyoshi Nakada <nobu@ruby-lang.org> Thu Dec 5 22:18:01 2013 Nobuyoshi Nakada <nobu@ruby-lang.org>
* lib/mkmf.rb (configuration): strip destdir part from prefix to get * lib/mkmf.rb (configuration): strip destdir part from prefix to get

13
ext/bigdecimal/bigdecimal.c
View File

@ -199,14 +199,23 @@ GetVpValueWithPrec(VALUE v, long prec, int must)
VALUE num, bg; VALUE num, bg;
char szD[128]; char szD[128];
VALUE orig = Qundef; VALUE orig = Qundef;
double d;
again: again:
switch(TYPE(v)) { switch(TYPE(v)) {
case T_FLOAT: case T_FLOAT:
if (prec < 0) goto unable_to_coerce_without_prec; if (prec < 0) goto unable_to_coerce_without_prec;
if (prec > DBL_DIG+1) goto SomeOneMayDoIt; if (prec > DBL_DIG+1) goto SomeOneMayDoIt;
v = rb_funcall(v, id_to_r, 0); d = RFLOAT_VALUE(v);
goto again; if (d != 0.0) {
v = rb_funcall(v, id_to_r, 0);
goto again;
}
if (1/d < 0.0) {
return VpCreateRbObject(prec, "-0");
}
return VpCreateRbObject(prec, "0");
case T_RATIONAL: case T_RATIONAL:
if (prec < 0) goto unable_to_coerce_without_prec; if (prec < 0) goto unable_to_coerce_without_prec;

3
test/bigdecimal/test_bigdecimal.rb
View File

@ -86,6 +86,9 @@ class TestBigDecimal < Test::Unit::TestCase
assert_raise(ArgumentError) { BigDecimal(0.1) } assert_raise(ArgumentError) { BigDecimal(0.1) }
assert_raise(ArgumentError) { BigDecimal(0.1, Float::DIG + 2) } assert_raise(ArgumentError) { BigDecimal(0.1, Float::DIG + 2) }
assert_nothing_raised { BigDecimal(0.1, Float::DIG + 1) } assert_nothing_raised { BigDecimal(0.1, Float::DIG + 1) }
bug9214 = '[ruby-core:58858]'
assert_equal(BigDecimal(-0.0, Float::DIG).sign, -1, bug9214)
end end
def test_global_new_with_big_decimal def test_global_new_with_big_decimal

6
test/bigdecimal/test_bigdecimal_util.rb
View File

@ -18,6 +18,9 @@ class TestBigDecimalUtil < Test::Unit::TestCase
assert_in_delta(BigDecimal(0.5, Float::DIG), 0.5.to_d, delta) assert_in_delta(BigDecimal(0.5, Float::DIG), 0.5.to_d, delta)
assert_in_delta(BigDecimal(355.0/113.0, Float::DIG), (355.0/113.0).to_d, delta) assert_in_delta(BigDecimal(355.0/113.0, Float::DIG), (355.0/113.0).to_d, delta)
assert_equal(9.05.to_d.to_s('F'), "9.05") assert_equal(9.05.to_d.to_s('F'), "9.05")
bug9214 = '[ruby-core:58858]'
assert_equal((-0.0).to_d.sign, -1, bug9214)
end end
def test_Float_to_d_with_precision def test_Float_to_d_with_precision
@ -25,6 +28,9 @@ class TestBigDecimalUtil < Test::Unit::TestCase
delta = 1.0/10**(digits) delta = 1.0/10**(digits)
assert_in_delta(BigDecimal(0.5, 5), 0.5.to_d(digits), delta) assert_in_delta(BigDecimal(0.5, 5), 0.5.to_d(digits), delta)
assert_in_delta(BigDecimal(355.0/113.0, 5), (355.0/113.0).to_d(digits), delta) assert_in_delta(BigDecimal(355.0/113.0, 5), (355.0/113.0).to_d(digits), delta)
bug9214 = '[ruby-core:58858]'
assert_equal((-0.0).to_d(digits).sign, -1, bug9214)
end end
def test_Rational_to_d def test_Rational_to_d