1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Bug #21153] Add missing op-assign to top const in command_asgn

Browse Source 
It was defined in `arg` only; moved that pattern to `op_asgn` rule to
share it with `command_asgn`.
This commit is contained in:
Nobuyoshi Nakada 2025-02-24 23:20:12 +09:00
parent c27f433d7c
commit 21ac0a3a64
No known key found for this signature in database
GPG Key ID: 3582D74E1FEE4465
2 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
parse.y
View File

@ -3037,6 +3037,12 @@ rb_parser_ary_free(rb_parser_t *p, rb_parser_ary_t *ary)
$$ = new_const_op_assign(p, NEW_COLON2($primary_value, $tCONSTANT, &loc), $tOP_ASGN, $rhs, $lex_ctxt, &@$);
/*% ripper: opassign!(const_path_field!($:1, $:3), $:4, $:6) %*/
}
| tCOLON3 tCONSTANT tOP_ASGN lex_ctxt rhs
{
YYLTYPE loc = code_loc_gen(&@tCOLON3, &@tCONSTANT);
$$ = new_const_op_assign(p, NEW_COLON3($tCONSTANT, &loc), $tOP_ASGN, $rhs, $lex_ctxt, &@$);
/*% ripper: opassign!(top_const_field!($:2), $:3, $:5) %*/
}
| backref tOP_ASGN lex_ctxt rhs
{
VALUE MAYBE_UNUSED(e) = rb_backref_error(p, $backref);
@ -3851,12 +3857,6 @@ reswords : keyword__LINE__ | keyword__FILE__ | keyword__ENCODING__
arg : asgn(lhs, arg_rhs)
| op_asgn(arg_rhs)
| tCOLON3 tCONSTANT tOP_ASGN lex_ctxt arg_rhs
{
YYLTYPE loc = code_loc_gen(&@1, &@2);
$$ = new_const_op_assign(p, NEW_COLON3($2, &loc), $3, $5, $4, &@$);
/*% ripper: opassign!(top_const_field!($:2), $:3, $:5) %*/
}
| arg tDOT2 arg
{
value_expr($1);

9
test/ruby/test_parse.rb
View File

@ -186,6 +186,15 @@ class TestParse < Test::Unit::TestCase
end;
end
c = Class.new
c.freeze
assert_valid_syntax("#{<<~"begin;"}\n#{<<~'end;'}") do
begin;
c::FOO &= p 1
::FOO &= p 1
end;
end
assert_syntax_error("#{<<~"begin;"}\n#{<<~'end;'}", /Can't set variable/) do
begin;
$1 &= 1