1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

class.c: prohibit refinement module

Browse Source 
* class.c (ensure_includable): cannot include refinement
  module, or the type and the class do not match.
  [ruby-core:79632] [Bug #13236]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58083 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
nobu 2017-03-25 03:23:43 +00:00
parent 19a1f70364
commit 217f599a1e
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
class.c
View File

@ -854,6 +854,9 @@ ensure_includable(VALUE klass, VALUE module)
{ {
rb_frozen_class_p(klass); rb_frozen_class_p(klass);
Check_Type(module, T_MODULE); Check_Type(module, T_MODULE);
if (!NIL_P(rb_refinement_module_get_refined_class(module))) {
rb_raise(rb_eArgError, "refinement module is not allowed");
}
OBJ_INFECT(klass, module); OBJ_INFECT(klass, module);
} }

14
test/ruby/test_refinement.rb
View File

@ -1886,6 +1886,20 @@ class TestRefinement < Test::Unit::TestCase
assert_equal("Parent -> Child", SuperToModule::Child.test, bug) assert_equal("Parent -> Child", SuperToModule::Child.test, bug)
end end
def test_include_refinement
bug = '[ruby-core:79632] [Bug #13236] cannot include refinement module'
r = nil
m = Module.new do
r = refine(String) {def test;:ok end}
end
assert_raise_with_message(ArgumentError, /refinement/, bug) do
m.module_eval {include r}
end
assert_raise_with_message(ArgumentError, /refinement/, bug) do
m.module_eval {prepend r}
end
end
private private
def eval_using(mod, s) def eval_using(mod, s)