1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add embedded status to dumps of T_OBJECT

Browse Source 
This commit adds `"embedded":true` in ObjectSpace.dump for T_OBJECTs
that are embedded.
This commit is contained in:
Peter Zhu 2023-01-05 10:55:44 -05:00
parent 53938efd7b
commit 2056c0a7c6
Notes: git 2023-01-05 21:01:01 +00:00 
Merged: https://github.com/ruby/ruby/pull/7068
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ext/objspace/objspace_dump.c
View File

@ -544,6 +544,10 @@ dump_object(VALUE obj, struct dump_config *dc)
break; break;
case T_OBJECT: case T_OBJECT:
if (FL_TEST(obj, ROBJECT_EMBED)) {
dump_append(dc, ", \"embedded\":true");
}
dump_append(dc, ", \"ivars\":"); dump_append(dc, ", \"ivars\":");
dump_append_lu(dc, ROBJECT_IV_COUNT(obj)); dump_append_lu(dc, ROBJECT_IV_COUNT(obj));
if (rb_shape_obj_too_complex(obj)) { if (rb_shape_obj_too_complex(obj)) {

16
test/objspace/test_objspace.rb
View File

@ -358,6 +358,22 @@ class TestObjSpace < Test::Unit::TestCase
assert_not_include(info, '"embedded":true') assert_not_include(info, '"embedded":true')
end end
def test_dump_object
klass = Class.new
# Empty object
info = ObjectSpace.dump(klass.new)
assert_include(info, '"embedded":true')
assert_include(info, '"ivars":0')
# Non-embed object
obj = klass.new
5.times { |i| obj.instance_variable_set("@ivar#{i}", 0) }
info = ObjectSpace.dump(obj)
assert_not_include(info, '"embedded":true')
assert_include(info, '"ivars":5')
end
def test_dump_control_char def test_dump_control_char
assert_include(ObjectSpace.dump("\x0f"), '"value":"\u000f"') assert_include(ObjectSpace.dump("\x0f"), '"value":"\u000f"')
assert_include(ObjectSpace.dump("\C-?"), '"value":"\u007f"') assert_include(ObjectSpace.dump("\C-?"), '"value":"\u007f"')