1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

class_or_module_required: do not goto into a branch

Browse Source 
I'm not necessarily against every goto in general, but jumping into a
branch is definitely a bad idea.  Better refactor.
This commit is contained in:
卜部昌平 2020-06-16 10:49:02 +09:00
parent 03354feb6a
commit 1f6e74106f
Notes: git 2020-06-29 11:06:58 +09:00 
Merged: https://github.com/ruby/ruby/pull/3247
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
object.c
View File

@ -827,15 +827,13 @@ rb_obj_inspect(VALUE obj)
static VALUE static VALUE
class_or_module_required(VALUE c) class_or_module_required(VALUE c)
{ {
if (SPECIAL_CONST_P(c)) goto not_class; switch (OBJ_BUILTIN_TYPE(c)) {
switch (BUILTIN_TYPE(c)) {
case T_MODULE: case T_MODULE:
case T_CLASS: case T_CLASS:
case T_ICLASS: case T_ICLASS:
break; break;
default: default:
not_class:
rb_raise(rb_eTypeError, "class or module required"); rb_raise(rb_eTypeError, "class or module required");
} }
return c; return c;